----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111480/#review35898 -----------------------------------------------------------
plasma/generic/applets/notifications/contents/ui/Notifications.qml <http://git.reviewboard.kde.org/r/111480/#comment26576> is the duplicated notification always guaranteed to be the first one? it may make more sense to have a hash of source/appName/summary/body/actions for each notification stored in a (Q)set and then checked for? - Aaron J. Seigo On July 12, 2013, 7:08 a.m., Cedric Bellegarde wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111480/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 7:08 a.m.) > > > Review request for kde-workspace and Marco Martin. > > > Description > ------- > > Do not replace notifications with same summary and body > > Here a patch similar to this colibri commit. > > See REVIEW: 110745 > http://quickgit.kde.org/?p=colibri.git&a=commit&h=9a96b9512579215bcddd8fc88041fdd7130dbb0f > > > This addresses bug 313440. > http://bugs.kde.org/show_bug.cgi?id=313440 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/Notifications.qml ce3f8de > > Diff: http://git.reviewboard.kde.org/r/111480/diff/ > > > Testing > ------- > > Working here > > > Thanks, > > Cedric Bellegarde > >
