----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112038/ -----------------------------------------------------------
Review request for kdelibs and Stephen Kelly. Description ------- The issue was uncovered by https://git.reviewboard.kde.org/r/111937. LibAttica::attica is in the LINK_PUBLIC entries for XmlGui and in the IMPORTED_LINK_DEPENDENT_LIBRARIES for KDE4__knewstuff3 but none of these is looking for Attica. With this patch, both KDELibs4Config.cmake and XmlGuiConfig.cmake look for Attica. Diffs ----- KDELibs4Config.cmake bd91efb staging/xmlgui/XmlGuiConfig.cmake.in 08da417 staging/xmlgui/src/CMakeLists.txt 46dc74a Diff: http://git.reviewboard.kde.org/r/112038/diff/ Testing ------- Konsole build with https://git.reviewboard.kde.org/r/111937 without the 'find_package(LibAttica NO_MODULE) line'. Thanks, Christophe Giboudeaux
