----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112081/#review37764 -----------------------------------------------------------
I'm not sure why I'm singled out as one of the "notable users"; everyone should use this - it's awesome. It is definitely worth including. I've got some minor comments. reviewboard-am <http://git.reviewboard.kde.org/r/112081/#comment27962> I don't understand the purpose of this default. The vast majority of the times I use reviewboard-am it's because the author doesn't have commit access. They won't then have a @kde email address. It seems to have more risk that I'll just hit enter and accidentally commit something with a really really wrong email address, whereas if you leave the default empty my git push will fail and I'll catch it. reviewboard-am <http://git.reviewboard.kde.org/r/112081/#comment27963> I've had this fail several times; bad review numbers, dodgy internet connection etc. A try+catch may make the output a lot less intimidating than the current exception backtraces. - David Edmundson On Aug. 14, 2013, 2:10 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112081/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2013, 2:10 p.m.) > > > Review request for kdelibs and David Edmundson. > > > Description > ------- > > Add reviewboard-am, a tool to apply patches from KDE reviewboard. > > (subscribing the "kdelibs" group to this request because there seems to be no > "kde-dev-scripts" group) > > > Diffs > ----- > > reviewboard-am PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112081/diff/ > > > Testing > ------- > > I and a few others, most notably David Edmundson, have been using it for > quite some time now. > > > Thanks, > > Aurélien Gâteau > >
