----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112042/#review37717 -----------------------------------------------------------
sorry, forgot to push my pending review... konqueror/src/konqbookmarkbar.cpp <http://git.reviewboard.kde.org/r/112042/#comment27895> How can m_toolBar be NULL, given this line in the only constructor? It gets deleted, and there's a QPointer? But then fillBookmarkBar might as well abort at the beginning of the method, at least? - David Faure On Aug. 16, 2013, 1:06 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112042/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 1:06 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Description > ------- > > This patch prevents Konqueror from crashing when adding/importing bookmarks. > > > This addresses bug 309370. > http://bugs.kde.org/show_bug.cgi?id=309370 > > > Diffs > ----- > > konqueror/src/konqbookmarkbar.cpp 4c2b6fd > > Diff: http://git.reviewboard.kde.org/r/112042/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
