> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is really that you can only use one icon theme at a time.
While it is a corner case I think we should find a solution to make this more solid. Perhaps we could set the theme name in the cache, and then check if it has changed, if so remove cache. What is a bug imho is that theme can be changed without the cache getting cleaned somehow, corner case if you want but a bug. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38986 ----------------------------------------------------------- On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112367/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2013, 8 p.m.) > > > Review request for KDE Frameworks, kdelibs and Michael Pyne. > > > Description > ------- > > If we make no difference between an icon from oxygen and an icon from > gnome, when we change themes for example from oxygen to gnome, the > icon will be found in the cache and won't be upgraded. > > > Diffs > ----- > > kdeui/icons/kiconloader.cpp ce6aeea > > Diff: http://git.reviewboard.kde.org/r/112367/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
