-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112328/#review39376
-----------------------------------------------------------


I'm thankfull to all of you for lloking into this! Now I do not know what to do 
with these changes. If there will bee no new kdelibs 4.x releases, how these 
changes can be released? Will it happen only with Frameworks 5?

- Eugene Shalygin


On Aug. 29, 2013, 3:11 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112328/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:11 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> There are number of people who want to have case sensitive sorting in file 
> manager and file dialogs (that would be consistent with locale settings).
> 
> The proposed patch adds a property to KGlobalSettings 
> (caseSensitiveSorting()) and the new signal sortingModeChanged(), which 
> deprecates naturalSortingChanged(), so the clients can connect to only one 
> event and do not resort their models twice (maybe and option for the event to 
> pass the change reason would be useful?).
> 
> KDirSortFilterProxyModel is changed in a trivial manner to use new event and 
> handle case sensitivity changes.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
>     
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.h 96da20e 
>   kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
>   kfile/kdirsortfilterproxymodel.h 63cf04c 
>   kfile/kdirsortfilterproxymodel.cpp 34ddcd2 
> 
> Diff: http://git.reviewboard.kde.org/r/112328/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

Reply via email to