----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review41277 -----------------------------------------------------------
Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However, mounting the same share through CIFS (mount.cifs) gives mu much greater speed with ~86MB/s. Is there anything you can do to make this about equal in speed compared to cifs? - Mark Gaiser On Oct. 5, 2013, 3:07 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112982/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2013, 3:07 p.m.) > > > Review request for KDE Runtime. > > > Bugs: 176271 and 291835 > http://bugs.kde.org/show_bug.cgi?id=176271 > http://bugs.kde.org/show_bug.cgi?id=291835 > > > Repository: kde-runtime > > > Description > ------- > > The attach patch adds support for the following to kio_smb: > > - copyToFile optimization so downloading files from window shares is faster. > - partial download resumption as part of the copyToFile implementation. > - preservation of modified file timstamp. Again as part of the copyToFile > implementation. > > Note that in this patch the latter two features only apply to "smb" -> "file" > downloads. The second part of this patch will that will follow soon will add > support for the other half, the "copyFromFile" optimization. > > > Diffs > ----- > > kioslave/smb/kio_smb.h 55efb44 > kioslave/smb/kio_smb_dir.cpp 5573266 > kioslave/smb/smb.protocol 654bcfb > > Diff: http://git.reviewboard.kde.org/r/112982/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >