> On Oct. 10, 2013, 10:16 a.m., Albert Astals Cid wrote: > > Was this commited? > > Also isn't a whole remove in the middle a bit too dangerous? > > Ömer Fadıl Usta wrote: > I had also some suspicions so i delayed commiting for check it on > different installed paths > on the other hand i forget to commit. so it didn't committed but i need > to check it again > before committing it. maybe we need to discard this review request until > i had time to check it again > and confirm if that bug still exists > > Aaron J. Seigo wrote: > the patch is obviously incorrect. the real question is why the plugin > name is duplicated, and that can only be because of a limited number of > reasons: the package defaultRoot includes the package name (which it > shouldn't), KStandardDirs (which should not be used, but the qt5 replacement > for it) is returning something wrong (which is very unlikely here) or > something is going wrong in PackageStructure. but removing the plugin name is > not the right answer, it just works around a symptom. > > I'll discard this review.
Note that this being 5 months old i am not sure it wanted to target master but the stable branch as a bugfix so not sure your KStandardirs/qt5 comment applies here. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/#review41480 ----------------------------------------------------------- On Oct. 10, 2013, 12:28 p.m., Ömer Fadıl Usta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110118/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2013, 12:28 p.m.) > > > Review request for kde-workspace, Aaron J. Seigo and Marco Martin. > > > Repository: kde-workspace > > > Description > ------- > > plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: > "/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" > invalid, basePath is "" > > it resets basePath due to double pluginname at the end of path. > > > Diffs > ----- > > plasma/desktop/shell/activitymanager/activitymanager.cpp 2ecb30d > > Diff: http://git.reviewboard.kde.org/r/110118/diff/ > > > Testing > ------- > > After this patch that warning about invalid path is gone. I have checked that > package->path() returning correct address now. > > > Thanks, > > Ömer Fadıl Usta > >
