----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113413/ -----------------------------------------------------------
Review request for KDE Runtime, kde-workspace and Andriy Rysin. Repository: kde-workspace Description ------- Improved keyboard layout preview added geometry feature, multi-level keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names. my GSoC-13 project ! Diffs ----- kcontrol/keyboard/CMakeLists.txt 973a39d kcontrol/keyboard/CMakeLists.txt f92c96b kcontrol/keyboard/CMakeLists.txt 59b366e kcontrol/keyboard/CMakeLists.txt 2f0589c kcontrol/keyboard/CMakeLists.txt d39d29e kcontrol/keyboard/CMakeLists.txt ee02f2c kcontrol/keyboard/CMakeLists.txt 6c51586 kcontrol/keyboard/CMakeLists.txt c9a0ae3 kcontrol/keyboard/CMakeLists.txt 3a2e729 kcontrol/keyboard/CMakeLists.txt ad92fa3 kcontrol/keyboard/CMakeLists.txt 973a39d kcontrol/keyboard/kcm_add_layout_dialog.h 5273347 kcontrol/keyboard/kcm_add_layout_dialog.h edf4336 kcontrol/keyboard/kcm_add_layout_dialog.h 5273347 kcontrol/keyboard/kcm_add_layout_dialog.cpp 444da8e kcontrol/keyboard/kcm_add_layout_dialog.cpp b9d4ac2 kcontrol/keyboard/kcm_add_layout_dialog.cpp 5a597a7 kcontrol/keyboard/kcm_add_layout_dialog.cpp 29ca074 kcontrol/keyboard/kcm_add_layout_dialog.cpp d893308 kcontrol/keyboard/kcm_add_layout_dialog.cpp 84bac6e kcontrol/keyboard/kcm_add_layout_dialog.cpp 444da8e kcontrol/keyboard/kcm_keyboard.ui f64eeea kcontrol/keyboard/kcm_keyboard_widget.h 58256df kcontrol/keyboard/kcm_keyboard_widget.h 58256df kcontrol/keyboard/kcm_keyboard_widget.cpp e513a41 kcontrol/keyboard/kcm_keyboard_widget.cpp 9d3f010 kcontrol/keyboard/kcm_keyboard_widget.cpp f71239a kcontrol/keyboard/kcm_keyboard_widget.cpp 8922dc6 kcontrol/keyboard/kcm_keyboard_widget.cpp ede5ce6 kcontrol/keyboard/kcm_keyboard_widget.cpp 72f4b4b kcontrol/keyboard/kcm_keyboard_widget.cpp c9a6910 kcontrol/keyboard/preview/TODO 784924f kcontrol/keyboard/preview/TODO 784924f kcontrol/keyboard/preview/geometry_components.h PRE-CREATION kcontrol/keyboard/preview/geometry_components.h 5723b01 kcontrol/keyboard/preview/geometry_components.h e10837a kcontrol/keyboard/preview/geometry_components.h 3381c10 kcontrol/keyboard/preview/geometry_components.h a99432a kcontrol/keyboard/preview/geometry_components.h d43368f kcontrol/keyboard/preview/geometry_components.h dc1cdde kcontrol/keyboard/preview/geometry_components.h 2a3347d kcontrol/keyboard/preview/geometry_components.h e686302 kcontrol/keyboard/preview/geometry_components.h d8e3ae8 kcontrol/keyboard/preview/geometry_components.h e814476 kcontrol/keyboard/preview/geometry_components.h PRE-CREATION kcontrol/keyboard/preview/geometry_components.cpp PRE-CREATION kcontrol/keyboard/preview/geometry_components.cpp 6c04078 kcontrol/keyboard/preview/geometry_components.cpp c31cbf4 kcontrol/keyboard/preview/geometry_components.cpp bdd8856 kcontrol/keyboard/preview/geometry_components.cpp dd3844a kcontrol/keyboard/preview/geometry_components.cpp e395e25 kcontrol/keyboard/preview/geometry_components.cpp 35d7e31 kcontrol/keyboard/preview/geometry_components.cpp 1d8b69e kcontrol/keyboard/preview/geometry_components.cpp 219b57b kcontrol/keyboard/preview/geometry_components.cpp 4ce3f87 kcontrol/keyboard/preview/geometry_components.cpp 3ce015a kcontrol/keyboard/preview/geometry_components.cpp PRE-CREATION kcontrol/keyboard/preview/geometry_parser.h PRE-CREATION kcontrol/keyboard/preview/geometry_parser.h 218b5ce kcontrol/keyboard/preview/geometry_parser.h d7d964f kcontrol/keyboard/preview/geometry_parser.h adf76dd kcontrol/keyboard/preview/geometry_parser.h 42657ce kcontrol/keyboard/preview/geometry_parser.h fcb5617 kcontrol/keyboard/preview/geometry_parser.h 9beed17 kcontrol/keyboard/preview/geometry_parser.h ed13270 kcontrol/keyboard/preview/geometry_parser.h d2adfbd kcontrol/keyboard/preview/geometry_parser.h e6bdf7a kcontrol/keyboard/preview/geometry_parser.h 20a9159 kcontrol/keyboard/preview/geometry_parser.h fc4ee6a kcontrol/keyboard/preview/geometry_parser.h e67b5c2 kcontrol/keyboard/preview/geometry_parser.h PRE-CREATION kcontrol/keyboard/preview/geometry_parser.cpp PRE-CREATION kcontrol/keyboard/preview/geometry_parser.cpp 9c16084 kcontrol/keyboard/preview/geometry_parser.cpp c5654e7 kcontrol/keyboard/preview/geometry_parser.cpp 3a76b4f kcontrol/keyboard/preview/geometry_parser.cpp 5e4f6f3 kcontrol/keyboard/preview/geometry_parser.cpp bd00836 kcontrol/keyboard/preview/geometry_parser.cpp a1e360c kcontrol/keyboard/preview/geometry_parser.cpp d3a2c99 kcontrol/keyboard/preview/geometry_parser.cpp d5bcd41 kcontrol/keyboard/preview/geometry_parser.cpp 7968242 kcontrol/keyboard/preview/geometry_parser.cpp 6882e7d kcontrol/keyboard/preview/geometry_parser.cpp 954aafb kcontrol/keyboard/preview/geometry_parser.cpp eb8dae3 kcontrol/keyboard/preview/geometry_parser.cpp 7a255be kcontrol/keyboard/preview/geometry_parser.cpp 06a51a1 kcontrol/keyboard/preview/geometry_parser.cpp ebb185e kcontrol/keyboard/preview/geometry_parser.cpp 7a2df28 kcontrol/keyboard/preview/geometry_parser.cpp 92f2af6 kcontrol/keyboard/preview/geometry_parser.cpp PRE-CREATION kcontrol/keyboard/preview/geometry_parser.cpp 89b8635 kcontrol/keyboard/preview/geometry_parser.cpp ebfee51 kcontrol/keyboard/preview/input PRE-CREATION kcontrol/keyboard/preview/input bbdb7c9 kcontrol/keyboard/preview/input1 PRE-CREATION kcontrol/keyboard/preview/input1 edf7c95 kcontrol/keyboard/preview/input2 PRE-CREATION kcontrol/keyboard/preview/input2 cef405c kcontrol/keyboard/preview/kbpreviewframe.h 23c8704 kcontrol/keyboard/preview/kbpreviewframe.h 45f6215 kcontrol/keyboard/preview/kbpreviewframe.h 3802231 kcontrol/keyboard/preview/kbpreviewframe.h e33f863 kcontrol/keyboard/preview/kbpreviewframe.h 2ab408e kcontrol/keyboard/preview/kbpreviewframe.h 74890f4 kcontrol/keyboard/preview/kbpreviewframe.h a4905be kcontrol/keyboard/preview/kbpreviewframe.h f8a3ee3 kcontrol/keyboard/preview/kbpreviewframe.h eee708e kcontrol/keyboard/preview/kbpreviewframe.h 8be2d18 kcontrol/keyboard/preview/kbpreviewframe.h bf1ed23 kcontrol/keyboard/preview/kbpreviewframe.h 23c8704 kcontrol/keyboard/preview/kbpreviewframe.cpp 8ecc4f2 kcontrol/keyboard/preview/kbpreviewframe.cpp 2f4f0a2 kcontrol/keyboard/preview/kbpreviewframe.cpp ba7e1e1 kcontrol/keyboard/preview/kbpreviewframe.cpp bb64227 kcontrol/keyboard/preview/kbpreviewframe.cpp f23ea93 kcontrol/keyboard/preview/kbpreviewframe.cpp f80acd8 kcontrol/keyboard/preview/kbpreviewframe.cpp f4397a1 kcontrol/keyboard/preview/kbpreviewframe.cpp 69437f3 kcontrol/keyboard/preview/kbpreviewframe.cpp b9378d3 kcontrol/keyboard/preview/kbpreviewframe.cpp 91a6a46 kcontrol/keyboard/preview/kbpreviewframe.cpp f6af4b6 kcontrol/keyboard/preview/kbpreviewframe.cpp c779c29 kcontrol/keyboard/preview/kbpreviewframe.cpp a7c8565 kcontrol/keyboard/preview/kbpreviewframe.cpp 6e13ed3 kcontrol/keyboard/preview/kbpreviewframe.cpp 4b9ab3d kcontrol/keyboard/preview/kbpreviewframe.cpp 8fe8f03 kcontrol/keyboard/preview/kbpreviewframe.cpp 8ecc4f2 kcontrol/keyboard/preview/kbpreviewframe_old.cpp PRE-CREATION kcontrol/keyboard/preview/kbpreviewframe_old.cpp 59bd573 kcontrol/keyboard/preview/kbpreviewframe_old.cpp d7bcca0 kcontrol/keyboard/preview/keyaliases.h 3769e4e kcontrol/keyboard/preview/keyaliases.h 3769e4e kcontrol/keyboard/preview/keyaliases.cpp 3eb45ec kcontrol/keyboard/preview/keyaliases.cpp b564595 kcontrol/keyboard/preview/keyaliases.cpp f040136 kcontrol/keyboard/preview/keyaliases.cpp 67a88f7 kcontrol/keyboard/preview/keyaliases.cpp 3eb45ec kcontrol/keyboard/preview/keyboardlayout.h 4844382 kcontrol/keyboard/preview/keyboardlayout.h 5c7484a kcontrol/keyboard/preview/keyboardlayout.h 1f84cf0 kcontrol/keyboard/preview/keyboardlayout.h 0ad3924 kcontrol/keyboard/preview/keyboardlayout.h fcac53d kcontrol/keyboard/preview/keyboardlayout.h 4844382 kcontrol/keyboard/preview/keyboardlayout.cpp 6ac2f3f kcontrol/keyboard/preview/keyboardlayout.cpp 86183d5 kcontrol/keyboard/preview/keyboardlayout.cpp e5dd50e kcontrol/keyboard/preview/keyboardlayout.cpp ae72bd0 kcontrol/keyboard/preview/keyboardlayout.cpp 5a7898a kcontrol/keyboard/preview/keyboardlayout.cpp ef66db9 kcontrol/keyboard/preview/keyboardlayout.cpp 6ac2f3f kcontrol/keyboard/preview/keyboardlayout_new.h PRE-CREATION kcontrol/keyboard/preview/keyboardlayout_new.h db74308 kcontrol/keyboard/preview/keyboardlayout_new.h 5c7484a kcontrol/keyboard/preview/keyboardlayout_new.cpp PRE-CREATION kcontrol/keyboard/preview/keyboardlayout_new.cpp 3feb997 kcontrol/keyboard/preview/keyboardlayout_new.cpp 42dbc63 kcontrol/keyboard/preview/keyboardpainter.h 39382be kcontrol/keyboard/preview/keyboardpainter.h 0008bbb kcontrol/keyboard/preview/keyboardpainter.h 3e46a4e kcontrol/keyboard/preview/keyboardpainter.h 5d7356c kcontrol/keyboard/preview/keyboardpainter.h d4a081c kcontrol/keyboard/preview/keyboardpainter.h 37450d9 kcontrol/keyboard/preview/keyboardpainter.h 8d7d3ea kcontrol/keyboard/preview/keyboardpainter.h 2cc3c1e kcontrol/keyboard/preview/keyboardpainter.h 39382be kcontrol/keyboard/preview/keyboardpainter.cpp b9fbf24 kcontrol/keyboard/preview/keyboardpainter.cpp 4067099 kcontrol/keyboard/preview/keyboardpainter.cpp c788a64 kcontrol/keyboard/preview/keyboardpainter.cpp 35f516f kcontrol/keyboard/preview/keyboardpainter.cpp 99e9274 kcontrol/keyboard/preview/keyboardpainter.cpp dbaeeef kcontrol/keyboard/preview/keyboardpainter.cpp aae740e kcontrol/keyboard/preview/keyboardpainter.cpp e46682d kcontrol/keyboard/preview/keyboardpainter.cpp a2cfcce kcontrol/keyboard/preview/keyboardpainter.cpp a2cfcce kcontrol/keyboard/preview/keyboardpainter.cpp e5e7e48 kcontrol/keyboard/preview/keyboardpainter.cpp 437906b kcontrol/keyboard/preview/keyboardpainter.cpp b9fbf24 kcontrol/keyboard/preview/keysymbols.h 8dfaee7 kcontrol/keyboard/preview/keysymbols.h 8dfaee7 kcontrol/keyboard/preview/keysymbols.cpp af43f62 kcontrol/keyboard/preview/keysymbols.cpp dc54e33 kcontrol/keyboard/preview/keysymbols.cpp af43f62 kcontrol/keyboard/preview/keysymhelper.cpp 67beb80 kcontrol/keyboard/preview/keysymhelper.cpp 67beb80 kcontrol/keyboard/preview/model_to_geometry.h PRE-CREATION kcontrol/keyboard/preview/model_to_geometry.h 07f8ae2 kcontrol/keyboard/preview/model_to_geometry.h a706ad9 kcontrol/keyboard/preview/model_to_geometry.h adc7792 kcontrol/keyboard/preview/model_to_geometry.h 0b617b8 kcontrol/keyboard/preview/model_to_geometry.h PRE-CREATION kcontrol/keyboard/preview/model_to_geometry.cpp PRE-CREATION kcontrol/keyboard/preview/model_to_geometry.cpp a99addb kcontrol/keyboard/preview/model_to_geometry.cpp 800bc9b kcontrol/keyboard/preview/model_to_geometry.cpp a3778b0 kcontrol/keyboard/preview/model_to_geometry.cpp a4cdeea kcontrol/keyboard/preview/model_to_geometry.cpp PRE-CREATION kcontrol/keyboard/preview/model_to_geometry.cpp eb9e434 kcontrol/keyboard/preview/model_to_geometry.cpp 59410ea kcontrol/keyboard/preview/symbol_parser.h PRE-CREATION kcontrol/keyboard/preview/symbol_parser.h bec1299 kcontrol/keyboard/preview/symbol_parser.h 7ce682d kcontrol/keyboard/preview/symbol_parser.h 0c94f55 kcontrol/keyboard/preview/symbol_parser.h efd5aca kcontrol/keyboard/preview/symbol_parser.h 85d5e7a kcontrol/keyboard/preview/symbol_parser.h 8148e08 kcontrol/keyboard/preview/symbol_parser.h 3d3690a kcontrol/keyboard/preview/symbol_parser.h 4e4ada2 kcontrol/keyboard/preview/symbol_parser.h PRE-CREATION kcontrol/keyboard/preview/symbol_parser.cpp PRE-CREATION kcontrol/keyboard/preview/symbol_parser.cpp 9b30bd8 kcontrol/keyboard/preview/symbol_parser.cpp 81ca951 kcontrol/keyboard/preview/symbol_parser.cpp 381663d kcontrol/keyboard/preview/symbol_parser.cpp dac8fe6 kcontrol/keyboard/preview/symbol_parser.cpp ea58219 kcontrol/keyboard/preview/symbol_parser.cpp f2cd34a kcontrol/keyboard/preview/symbol_parser.cpp 184c4d1 kcontrol/keyboard/preview/symbol_parser.cpp 9eabd91 kcontrol/keyboard/preview/symbol_parser.cpp 6a76fb8 kcontrol/keyboard/preview/symbol_parser.cpp PRE-CREATION kcontrol/keyboard/tests/CMakeLists.txt b2bbedc kcontrol/keyboard/tests/CMakeLists.txt d06b1b4 kcontrol/keyboard/tests/CMakeLists.txt eb0dd1e kcontrol/keyboard/tests/CMakeLists.txt 102b50e kcontrol/keyboard/tests/CMakeLists.txt b818a18 kcontrol/keyboard/tests/CMakeLists.txt b2bbedc kcontrol/keyboard/tests/base_file_parser_test.cpp PRE-CREATION kcontrol/keyboard/tests/base_file_parser_test.cpp PRE-CREATION kcontrol/keyboard/tests/geometry_parser_test.cpp PRE-CREATION kcontrol/keyboard/tests/geometry_parser_test.cpp c1eff3b kcontrol/keyboard/tests/geometry_parser_test.cpp PRE-CREATION kcontrol/keyboard/tests/symbol_parser_test.cpp PRE-CREATION kcontrol/keyboard/tests/symbol_parser_test.cpp PRE-CREATION kcontrol/keyboard/x11_helper.h 31f76f9 kcontrol/keyboard/x11_helper.h 69490d6 kcontrol/keyboard/x11_helper.cpp ebd09f3 kcontrol/keyboard/x11_helper.cpp f8060fb kcontrol/keyboard/xkb_helper.cpp 60bf5a8 kcontrol/keyboard/xkb_helper.cpp 60bf5a8 kcontrol/keyboard/xkb_rules.h 2be8562 kcontrol/keyboard/xkb_rules.h 2be8562 kcontrol/keyboard/xkb_rules.cpp 616e7b8 kcontrol/keyboard/xkb_rules.cpp 616e7b8 kwin/tabbox/kwindesktopswitcher.desktop 42cc455 Diff: http://git.reviewboard.kde.org/r/113413/diff/ Testing ------- Thanks, shivam makkar