----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review43700 -----------------------------------------------------------
Ship it! kioslave/smb/kio_smb_dir.cpp <http://git.reviewboard.kde.org/r/112982/#comment31403> Remove TODO ? kioslave/smb/kio_smb_dir.cpp <http://git.reviewboard.kde.org/r/112982/#comment31404> Remove unnecessary if(), we exited earlier if srcfd < 0 - David Faure On Nov. 14, 2013, 2:15 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112982/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 2:15 p.m.) > > > Review request for KDE Runtime and David Faure. > > > Bugs: 176271 and 291835 > http://bugs.kde.org/show_bug.cgi?id=176271 > http://bugs.kde.org/show_bug.cgi?id=291835 > > > Repository: kde-runtime > > > Description > ------- > > The attach patch adds support for the following to kio_smb: > > - copyToFile/copyFromFile optimizations so uploading and downloading files > from window shares is faster so long as one end is a local file. > - partial download resumption as part of the copyToFile implementation. > - preservation of modified file timstamp. Again as part of the copyToFile > implementation. > > > Diffs > ----- > > kioslave/smb/kio_smb.h 55efb44 > kioslave/smb/kio_smb_dir.cpp 186b687 > kioslave/smb/kio_smb_internal.h b895b81 > kioslave/smb/kio_smb_internal.cpp 3c35583 > kioslave/smb/smb.protocol 654bcfb > > Diff: http://git.reviewboard.kde.org/r/112982/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
