----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113915/#review43921 -----------------------------------------------------------
No. It is not acceptable to set the maximum xfer buffer size to such a large value. See http://blogs.msdn.com/b/openspecification/archive/2009/04/10/smb-maximum-transmit-buffer-size-and-performance-tuning.aspx - Dawit Alemayehu On Nov. 17, 2013, 8:33 p.m., Federico Cuello wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113915/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2013, 8:33 p.m.) > > > Review request for KDE Runtime. > > > Bugs: 291835 > http://bugs.kde.org/show_bug.cgi?id=291835 > > > Repository: kde-runtime > > > Description > ------- > > Fixes #291835 > > Several reports show that a buffer size increase greatly improves transfer > speed. > > > Diffs > ----- > > kioslave/smb/kio_smb.h 55efb44 > > Diff: http://git.reviewboard.kde.org/r/113915/diff/ > > > Testing > ------- > > > Thanks, > > Federico Cuello > >