> On Dec. 5, 2013, 12:23 a.m., Pino Toscano wrote: > > ksplash/ksplashqml/SplashApp.cpp, lines 148-150 > > <http://git.reviewboard.kde.org/r/114298/diff/1/?file=222537#file222537line148> > > > > What about just calling > > ::exit(2) > > to reach the stdlib function, avoiding the exitNow "wrapper"?
So that's how one does that xD Thanks for the tip! - Harald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114298/#review45154 ----------------------------------------------------------- On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114298/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 1:54 p.m.) > > > Review request for kde-workspace and Ivan Čukić. > > > Repository: kde-workspace > > > Description > ------- > > Do not crash when failing to load a theme, but instead exit. > > When failing to load the theme's qml file QDeclarativeView goes into error > state, at which point we want to exit to prevent nullptr access problems. > > > Diffs > ----- > > ksplash/ksplashqml/SplashApp.cpp 7c528d056ee680f69a6d3d60d1dbeeae9d548846 > > Diff: http://git.reviewboard.kde.org/r/114298/diff/ > > > Testing > ------- > > ksplashqml Foo --test > > -> sigsev without patch > -> exits with patch > > > Thanks, > > Harald Sitter > >