----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/#review46971 -----------------------------------------------------------
src/core/global.cpp <https://git.reviewboard.kde.org/r/114889/#comment33517> The messages are no longer dumb (i.e. they have proper argument substitution), so all these comments should be removed. - Chusslove Illich On Jan. 6, 2014, 8 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114889/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 8 p.m.) > > > Review request for kdelibs. > > > Repository: kio > > > Description > ------- > > Seems the code behind i18n() in kf5 does not like %-placeholders without any > arguments passed in the i18n call. And thus inserts the warning. > (Effect can be seen e.g. in Okteta's File Info tool). > > Attached patch fixes that, by delaying the argument substitution as proposed > in > http://api.kde.org/frameworks-5.x-api/frameworks-apidocs/ki18n/html/prg_guide.html#spec_usage > > > Diffs > ----- > > src/core/global.cpp 42f453b > > Diff: https://git.reviewboard.kde.org/r/114889/diff/ > > > Testing > ------- > > Results of KIO::convertSize(...) displays fine in Okteta with the patch. > > > Thanks, > > Friedrich W. H. Kossebau > >
