----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115056/#review47524 -----------------------------------------------------------
Looks good from my side. I'll let Martin have the final ship-it say. Thanks for the patch! - Sebastian Kügler On Jan. 16, 2014, 5:02 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115056/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 5:02 p.m.) > > > Review request for kde-workspace and Martin Klapetek. > > > Repository: kde-workspace > > > Description > ------- > > Rename the knotifications StatusNotifier dbus interface. This prevents > installing interface files which overlap with the kdelibs4 equivalents. > Goes with https://git.reviewboard.kde.org/r/115055/ > > > Diffs > ----- > > plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt 4e3724b > plasma/generic/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp > 04db8e0 > statusnotifierwatcher/CMakeLists.txt d2ffeec > statusnotifierwatcher/statusnotifierwatcher.cpp 647d093 > > Diff: https://git.reviewboard.kde.org/r/115056/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
