----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114454/#review47527 -----------------------------------------------------------
This review has been submitted with commit fcff9a08fc28d5ad1f8862939ec251c2fd1273d3 by Bernd Buschinski to branch KDE/4.12. - Commit Hook On Dec. 14, 2013, 6:53 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114454/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2013, 6:53 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > kjs: Implement ES6 Math.hypot > > I agree that the loop, that is just checking for Inf looks weird, but thats > what the spec says. > We MUST check everything first for Inf, NaN checks must come later. > > So a (1, NaN, Inf) must return Inf. > > > Diffs > ----- > > kjs/math_object.h 3d193dd > kjs/math_object.cpp 89835e5 > > Diff: https://git.reviewboard.kde.org/r/114454/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Buschinski > >
