----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114455/#review47707 -----------------------------------------------------------
This review has been submitted with commit ba2606233662d115474406e84b64e4fae965ff0b by Bernd Buschinski to branch master. - Commit Hook On Jan. 16, 2014, 5:56 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114455/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 5:56 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > kjs: Implement ES6 Math.imul > > I admit I am totally lost here, I need help, the specs just confuse me. The > code doesn't look like it does anything useful. > > step 1 to 4 is just getting the values. > a and b must be a uint32_t. > > 5. Let product be (a * b) modulo 2^32. > 6. If product ? 2^31, return product - 2^32, otherwise return product. > > (Taken from ES6 draft 08.11.2013) > > This is the part I don't understand at all. > I am not even sure about the product datatype. > > Also NOTE: the JSC and firefox implementation look totally different and both > return different values in highvalue cases, so I rather not trust them. > > > Diffs > ----- > > kjs/math_object.h 3d193dd > kjs/math_object.cpp 89835e5 > > Diff: https://git.reviewboard.kde.org/r/114455/diff/ > > > Testing > ------- > > > Thanks, > > Bernd Buschinski > >
