On Wednesday 22 January 2014 00:16:05 Albert Astals Cid wrote:
> El Dimarts, 21 de gener de 2014, a les 11:56:33, Vishesh Handa va escriure:
> > On Monday 20 January 2014 22:38:52 Albert Astals Cid wrote:
> > > Also make sure all the classes have a d-pointer in case they need to be
> > > expanded in the future you can keep ABI.
> > 
> > Fixed.
> 
> Maybe even add one to ExtractorPlugin in case you need to add stuff in there
> later?
> 

I didn't think I would need it in the future, but you're right. It's better to 
be safe.

> What about moving
> ExtractorPluginManager::allExtractors to the private?
> 

Fixed.

-- 
Vishesh Handa

Reply via email to