----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115651/#review49792 -----------------------------------------------------------
This review has been submitted with commit 944eb352595a912fc829b1fca4edfca7d00c4de1 by Dawit Alemayehu to branch KDE/4.12. - Commit Hook On Feb. 11, 2014, 10:28 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115651/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 10:28 a.m.) > > > Review request for kdelibs, Andreas Hartmetz and David Faure. > > > Bugs: 330795 > http://bugs.kde.org/show_bug.cgi?id=330795 > > > Repository: kdelibs > > > Description > ------- > > The attached patch fixes how we handle HTTP redirection. Currently KIO does > not correctly handle a "303 See Other" response. Instead of converting the > redirection request to a GET operation as specified in the RFC, KIO simply > repeats the same operation with the redirect URL. Additionally, KIO does not > handle redirection of a delete operation that is handled internally. > > > Diffs > ----- > > kio/DESIGN.metadata 1351119 > kio/kio/accessmanager.cpp 7a806e8 > kio/kio/job.cpp 13107c2 > kioslave/http/http.cpp b13eed1 > > Diff: https://git.reviewboard.kde.org/r/115651/diff/ > > > Testing > ------- > > Run tests at > > http://greenbytes.de/tech/tc/httpredirects/t301methods.html > http://greenbytes.de/tech/tc/httpredirects/t302methods.html > http://greenbytes.de/tech/tc/httpredirects/t303methods.html > > > Thanks, > > Dawit Alemayehu > >
