----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115183/#review49807 -----------------------------------------------------------
This review has been submitted with commit 5ec7c15faec9d3d9d26c43acfcd144d9b3234896 by Jonathan Marten to branch KDE/4.11. - Commit Hook On Jan. 21, 2014, 4:23 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115183/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 4:23 p.m.) > > > Review request for kde-workspace. > > > Bugs: 314690 > http://bugs.kde.org/show_bug.cgi?id=314690 > > > Repository: kde-workspace > > > Description > ------- > > The referenced bug describes a recent change in the KRunner command history > which makes recalling previous commands confusing, and different to the way > that history recall works in Bash and other shells. I don't know whether > this change was deliberate or accidental, but in the interests of consistency > this patch ensures that the command history is reset to the beginning when > showing the runner. > > > Diffs > ----- > > krunner/interfaces/default/interface.cpp 505e0aa > > Diff: https://git.reviewboard.kde.org/r/115183/diff/ > > > Testing > ------- > > Built kde-workspace with this change, verified operation of runner history. > Also verified by another bug reporter. > > > Thanks, > > Jonathan Marten > >
