> On Feb. 26, 2014, 9:32 p.m., Rolf Eike Beer wrote: > > When you start poking at this code, why not kill the entire > > fopen/fgets/fixed size buffer stuff and replace it with std streams or > > something like that?
I don't really know what kstartupconfig is supposed to do. This means I don't feel comfortable with touching that code since I could introduce some regressions/behaviour changes. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/#review50982 ----------------------------------------------------------- On Feb. 26, 2014, 7:11 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116097/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 7:11 p.m.) > > > Review request for kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > No longer use strlcpy in kstartupconfig > > This means we no longer need to find libbsd on Linux. > kstartupconfig is now uses std::string instead of pure C strings, but > the performance difference should be minimal (and it is less error-prone). > > > Diffs > ----- > > CMakeLists.txt bce3cd1de65b8420a859c342db981919965071ba > cmake/modules/FindLibBSD.cmake 6383083023cdbfbeffcab0cef98f48102e593d38 > kstartupconfig/CMakeLists.txt ceebd6a65af4cdaa717cfb0dcff5097121cf48d9 > kstartupconfig/kstartupconfig.c d8e65f48a75dad49fe6c585f89260c2a6d483809 > > Diff: https://git.reviewboard.kde.org/r/116097/diff/ > > > Testing > ------- > > compiles > > > Thanks, > > Alexander Richardson > >