> On March 8, 2014, 12:40 p.m., Andrea Iacovitti wrote: > > I'm a bit lost with your latest patch uploaded... > > > > Speaking about the third patch in this review (Diff r3) it seems it works > > as expected. That is if a server redirects a collection DELETE operation to > > a new Location with trailing slash added, redirection is correctly followed. > > From my part it is a ship for this one (Diff r3).
Sorry I posted the wrong patch!! Will post the correct one. It is the same as Diff r3 except it adds a trailing slash to the directory URL before sending it to the http ioslave. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52381 ----------------------------------------------------------- On March 7, 2014, 6:05 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116122/ > ----------------------------------------------------------- > > (Updated March 7, 2014, 6:05 a.m.) > > > Review request for kdelibs, Andrea Iacovitti and David Faure. > > > Bugs: 331295 > http://bugs.kde.org/show_bug.cgi?id=331295 > > > Repository: kdelibs > > > Description > ------- > > This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, > which attempted to workaround webdav servers that do not accept delete > requests on directories unless there is a trailing slash. It ensures that the > "fix" is only applicable to webdav and the addition of the trailing slash is > communicated to the client application. > > > Diffs > ----- > > kioslave/http/http.cpp 9eba5d1 > > Diff: https://git.reviewboard.kde.org/r/116122/diff/ > > > Testing > ------- > > For HTTP delete: > http://greenbytes.de/tech/tc/httpredirects/t301methods.html > > For WebDAV delete: > http://boonfaya.com/sites/webdavapps.com/#targets > > > Thanks, > > Dawit Alemayehu > >