----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/#review58481 -----------------------------------------------------------
kdm/backend/dm.h <https://git.reviewboard.kde.org/r/112294/#comment40678> Yes, leftover, will remove kdm/backend/dm.c <https://git.reviewboard.kde.org/r/112294/#comment40679> nope, will fix kdm/backend/dm.c <https://git.reviewboard.kde.org/r/112294/#comment40681> thanks for the clarification, will fix kdm/backend/dm.c <https://git.reviewboard.kde.org/r/112294/#comment40683> Hm, I prefer this notation, in particular as this is the same as for std::string (guaranteed since C++03, working for all versions of C++): std::string foo(100, '\0'); char* buf = &foo[10]; vs char foo[100] = { '\0' }; char *buf &foo[10]; This is correct, as arrays (both C and C++) are guaranteed to be contiguous, and thus (&foo[10]) == (foo + 10). kdm/backend/dm.c <https://git.reviewboard.kde.org/r/112294/#comment40686> Nope. After systemdHandleChange() we will repeat the while(...) loop, calling: startDisplays(); which calls: forEachDisplay(checkDisplayStatus); which does: if ((d->displayType & d_origin) == dFromFile && !d->stillThere) stopDisplay(d); kdm/backend/resource.c <https://git.reviewboard.kde.org/r/112294/#comment40688> They are: http://domainkeys.sourceforge.net/underscore.html kdm/backend/resource.c <https://git.reviewboard.kde.org/r/112294/#comment40689> see above kdm/backend/session.c <https://git.reviewboard.kde.org/r/112294/#comment40690> Will remove - Stefan Brüns On May 26, 2014, 12:06 a.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112294/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 12:06 a.m.) > > > Review request for kde-workspace and Oswald Buddenhagen. > > > Repository: kde-workspace > > > Description > ------- > > This patch implements dynamic multiseat in KDM. It follows the description in: > http://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/ > > In case systemd is no found at compile time, nothing changes. If logind is > not running, nothing changes. If no additional seats have been configured > (some Plugable USB-GPUs are automatically added as additional seats), nothing > changes. > > In case there are additional seats beyond seat0, a reserved display is > promoted to a local static one (and demoted if the seat is removed) and a new > X-Server/greeter is spawned. > > The code has been tested extensively, with a combination of [Radeon dedicated > GPU|Intel iGPU], [Intel iGPU|Displaylink USB GPU] and others. For history of > this patch, see https://bugzilla.redhat.com/show_bug.cgi?id=884271 and > https://bugzilla.redhat.com/show_bug.cgi?id=975079 > > > Diffs > ----- > > cmake/modules/CMakeLists.txt 117b3a5 > kdm/ConfigureChecks.cmake b61fd90 > kdm/backend/CMakeLists.txt 25f383f > kdm/backend/client.c a2d06c2 > kdm/backend/dm.h b2f8c61 > kdm/backend/dm.c 77a2ef7 > kdm/backend/dpylist.c b650c2f > kdm/backend/resource.c 38a8c70 > kdm/backend/server.c d8dd6f3 > kdm/backend/session.c 0e7901c > kdm/config-kdm.h.cmake 3e8912d > kdm/kfrontend/kdm_config.c 368c8d1 > > Diff: https://git.reviewboard.kde.org/r/112294/diff/ > > > Testing > ------- > > Single seat system, several multiseat systems > > > Thanks, > > Stefan Brüns > >
