> On June 10, 2014, 4:40 p.m., David Edmundson wrote: > > .toString() would be better if it still works, as that still keeps the URL > > scheme.
In kurl.h it's said that it's forbidden to use toString(), and to use url(), prettyUrl(), or pathOrUrl() instead. But none of them work as expected. - Victor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118604/#review59713 ----------------------------------------------------------- On June 7, 2014, 4:43 p.m., Victor Dodon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118604/ > ----------------------------------------------------------- > > (Updated June 7, 2014, 4:43 p.m.) > > > Review request for kdelibs, Albert Vaca Cintora and Aaron J. Seigo. > > > Bugs: 335922 > http://bugs.kde.org/show_bug.cgi?id=335922 > > > Repository: kdelibs > > > Description > ------- > > Only when selecting multiple files in KFileDialog, if a file contains in the > name the characters '#' or '%', it is (wrongly) escaped. > > The only modification needed is in kfilewidget.cpp, in slotOk, instead of > appending to the stringList the pretty url, append the url.toLocalFile, to > prevent the double escaping. > > > Diffs > ----- > > kfile/kfilewidget.cpp fc9b169 > > Diff: https://git.reviewboard.kde.org/r/118604/diff/ > > > Testing > ------- > > > Thanks, > > Victor Dodon > >
