----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118858/#review60648 -----------------------------------------------------------
Ship it! A good workaround until we understand how to get rid of nested event loops. - Christoph Feck On June 21, 2014, 8:26 a.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118858/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 8:26 a.m.) > > > Review request for kdelibs. > > > Bugs: 293863 > http://bugs.kde.org/show_bug.cgi?id=293863 > > > Repository: kdelibs > > > Description > ------- > > KUrlNavigator opens menus with exec() in a few places, and accesses member > variables or pointers to children after that. This can cause crashes if the > object has been deleted inside the nested event loops. > > This can be fixed by using QPointers to detect if an object was deleted > already, and return immediately in that case. > > > Diffs > ----- > > kfile/kurlnavigator.cpp f5dfc81 > kfile/kurlnavigatorbutton.cpp 6cb40b1 > > Diff: https://git.reviewboard.kde.org/r/118858/diff/ > > > Testing > ------- > > Cannot reproduce the crashes any more. The menus in KUrlNavigator still work > fine for me. > > > Thanks, > > Frank Reininghaus > >
