----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118954/#review61348 -----------------------------------------------------------
kinit/klauncher.cpp <https://git.reviewboard.kde.org/r/118954/#comment42724> Wait, what if url isn't a local file, but a remote one? This is missing a if (url.isLocalFile()) check. (same in krun, same in the forwardports to framework) - David Faure On June 29, 2014, 4:06 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118954/ > ----------------------------------------------------------- > > (Updated June 29, 2014, 4:06 p.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 142597 > http://bugs.kde.org/show_bug.cgi?id=142597 > > > Repository: kdelibs > > > Description > ------- > > The attached patch sets the current directory to the current working > directory (read: directory in which the open with dialog was run) whenever > the KService path is empty. That way we tell KProcess in the context of the > current directory instead of the default one it uses, $HOME. > > > Diffs > ----- > > kinit/klauncher.cpp 6c71e99 > kio/kio/krun.cpp 590fcf8 > > Diff: https://git.reviewboard.kde.org/r/118954/diff/ > > > Testing > ------- > > Tested with the example provided in the bug report. Verified the output of > the compile process is in the current working directory instead of $HOME. > > > Thanks, > > Dawit Alemayehu > >
