> On July 12, 2014, 6:01 p.m., Martin Gräßlin wrote: > > Which branch should that go in? I do not know what is currently a release > > branch. > > > > It should probably also be forward ported to frameworks even if the Mac > > part is currently not compiled (hint: if someone adjusts the code it could > > be included again ;-) ).
I do not know where fixes like this should go to. This patch is based on master. > On July 12, 2014, 6:01 p.m., Martin Gräßlin wrote: > > kdeui/windowmanagement/kwindowinfo_mac.cpp, line 54 > > <https://git.reviewboard.kde.org/r/119240/diff/2/?file=289759#file289759line54> > > > > what's the "RJVB 20140706" standing for? That's René's original comment. It will be taken out once this is ready for commit, since credit will be given by the commit message then. :) - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119240/#review62192 ----------------------------------------------------------- On July 12, 2014, 4:22 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119240/ > ----------------------------------------------------------- > > (Updated July 12, 2014, 4:22 p.m.) > > > Review request for kdelibs, Martin Gräßlin, Ian Wadham, and Thomas Lübking. > > > Bugs: 337154 > http://bugs.kde.org/show_bug.cgi?id=337154 > > > Repository: kdelibs > > > Description > ------- > > Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to > René J.V. Bertin) > > > Diffs > ----- > > kdeui/windowmanagement/kwindowinfo_mac.cpp > ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 > > Diff: https://git.reviewboard.kde.org/r/119240/diff/ > > > Testing > ------- > > For more details see associated bug > > > Thanks, > > Marko Käning > >
