> On July 15, 2014, 1:31 p.m., David Faure wrote: > > kdecore/io/kurl.cpp, line 1100 > > <https://git.reviewboard.kde.org/r/119221/diff/1/?file=289611#file289611line1100> > > > > This comparison should be case insensitive, see > > (QString::compare(scheme(), QLatin1String("mailto"), Qt::CaseInsensitive) > > == 0 in KUrl::url().
Ack. There seem to be a bunch of other case-sensitive comparison with the scheme in kurl. - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119221/#review62400 ----------------------------------------------------------- On July 16, 2014, 9:40 p.m., Felix Geyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119221/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 9:40 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > ------- > > KUrl::prettyUrl() rewrites mailto: URLs als mailto:// if the "path" is empty. > MUAs don't handle mailto:// URLs correctly. > > mailto:[email protected] > and > mailto:[email protected] > are both valid and semantically equivalent. > > KUrl::prettyUrl() converts the latter one to mailto://[email protected] > > This works fine: > kde-open mailto:[email protected] > > but this fails: > kde-open mailto:[email protected] > > For example with Thunderbird it creates a mail with: > To: // > To: [email protected] > > The mailto:// behavior was introduced with > http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=c67bfaf855e2345fd08951172e5fb32b38804fa5 > > The proposed change special cases mailto so it always uses mailto: instead of > mailto://. > > > Diffs > ----- > > kdecore/io/kurl.cpp 8c491f7 > kdecore/tests/kurltest.cpp 1fd204f > > Diff: https://git.reviewboard.kde.org/r/119221/diff/ > > > Testing > ------- > > Tested with kdelibs 4.13.2 and Thunderbird, Evolution and KMail. > > > Thanks, > > Felix Geyer > >
