On Июль 19, 2014, 1:17 д.п., Vadim Zhukov wrote: > > (As a general note, for build system related stuff like this you can also > > try including the "buildsystem" group, which can be more responsive at > > times) > > > > > The ibus-panel can't build on OpenBSD because some required definitions > > > obtained from pkgconfig file are not used. > > > 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt > > > > Can you post the error you get here? I've tried building kimtoy here on > > FreeBSD expecting to hit the same issue(s), but it all went along just fine. > > > > > 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at > > > compile time > > > > This doesn't make much sense; all values found at configuration time in > > CMake are then used to generate your make/ninja/whatever files, regardless > > of whether they are cached or not.
Raphael, thank you for your input! The issue was caused by the fact that X includes are placed in the /usr/X11R6/include directory on OpenBSD. This catalog is mentioned in PC_IBUS_DEFINITIONS variable but isn't propagated to the caller of find_package(IBus). Yes, I was wrong: the CACHE part may and should be omitted. This patch was added by me a long time ago (7 Feb 2012 according to git log; guess the KDE version used then), when I was much less expirienced in CMake... I've started a massive push of OpenBSD local patches upstream recently during OpenBSD hackathon, when I got time for such cleanup. At the present time, the /usr/X11R6/include gets to the include_directories() from another place, so the patch isn't required at all. But, still, the PC_IBUS_DEFINITIONS should be respected, IMHO. What do you think? Please note that FreeBSD and OpenBSD and quiet different. So you can't test on one OS instead of another. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/#review62669 ----------------------------------------------------------- On Июль 12, 2014, 5:12 п.п., Vadim Zhukov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119025/ > ----------------------------------------------------------- > > (Updated Июль 12, 2014, 5:12 п.п.) > > > Review request for kde-workspace, Plasma and Hui Ni. > > > Repository: kimtoy > > > Description > ------- > > The ibus-panel can't build on OpenBSD because some required definitions > obtained from pkgconfig file are not used. This happens due to the following > reasons: > > 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt > 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at > compile time > > This patch resolves both issues and makes ibus-panel compile on OpenBSD. > > (I found no suitable review group and therefore used "plasma" instead, as it > was in "plasma-addons" previously; please, feel free to correct me if I'm > wrong and sorry for any possible inconvenience) > > ((as there was no feedback for more than a week, I've added "kde-workspace" > group to list of reviewers, too)) > > > Diffs > ----- > > cmake/FindIBus.cmake 8250c49 > ibus-panel/CMakeLists.txt 3a1ee49 > > Diff: https://git.reviewboard.kde.org/r/119025/diff/ > > > Testing > ------- > > OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, > but the code is same) > > > Thanks, > > Vadim Zhukov > >
