----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/#review64997 -----------------------------------------------------------
Ship it! src/widgets/kdesktopfileactions.cpp <https://git.reviewboard.kde.org/r/119869/#comment45428> QLatin1String is sufficient, for comparisons - David Faure On Aug. 21, 2014, 1:15 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119869/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 1:15 p.m.) > > > Review request for KDE Frameworks, kdelibs and Frank Reininghaus. > > > Bugs: 235457 > https://bugs.kde.org/show_bug.cgi?id=235457 > > > Repository: kio > > > Description > ------- > > My attempt at fixing [bug 235457](https://bugs.kde.org/show_bug.cgi?id=235457) > We give .directory the default Type 'Directory' and a way for > KDesktopFileActions to handle .directory files. > To do that we trick KRun in opening the file as plain text. > > hasDirectoryType is a new method in KConfig. see: > [119868](https://git.reviewboard.kde.org/r/119868/) > Anything I should look out for when commiting this to KConfig and KIO? > > > Diffs > ----- > > src/widgets/kdesktopfileactions.cpp 9486015 > > Diff: https://git.reviewboard.kde.org/r/119869/diff/ > > > Testing > ------- > > Configure a folder with a custom icon in dolphin. Click the created > .directory file. > > > Thanks, > > Maarten De Meyer > >
