----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372/#review66430 -----------------------------------------------------------
Interesting, didn't know about this posix restriction (a bit inconsistent imho, the readonly dir vs readonly file difference). lib/konq/konq_operations.cpp <https://git.reviewboard.kde.org/r/119372/#comment46568> In fact this .directory() is wrong on windows (confusion between url-path and local file). Let's reverse the tests, to use the pathInfo object in order to get the parent directory. } else { QFileInfo itemInfo((*it).toLocalFile()); QFileInfo dirInfo(itemInfo.absolutePath()); // Posix does [....] if (dirInfo.isWritable() && (!itemInfo.isDir() || itemInfo.isWritable()) { ... Does this work? In that case, feel free to ship it :-) lib/konq/konq_operations.cpp <https://git.reviewboard.kde.org/r/119372/#comment46335> not path(), but toLocalFile() - David Faure On July 22, 2014, 7:56 a.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119372/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 7:56 a.m.) > > > Review request for KDE Base Apps. > > > Bugs: 337486 > http://bugs.kde.org/show_bug.cgi?id=337486 > > > Repository: kde-baseapps > > > Description > ------- > > Fixes Bug 337486 > > > Diffs > ----- > > lib/konq/konq_operations.cpp 220a90a > > Diff: https://git.reviewboard.kde.org/r/119372/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
