----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120354/#review67428 -----------------------------------------------------------
kglobalaccel/main.cpp <https://git.reviewboard.kde.org/r/120354/#comment47057> looks like an unrelated code line deletion. - Martin Gräßlin On Sept. 25, 2014, 4:58 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120354/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 4:58 p.m.) > > > Review request for KDE Software on Mac OS X, KDE Runtime, kdelibs, and Qt KDE. > > > Repository: kde-runtime > > > Description > ------- > > See https://bugs.kde.org/show_bug.cgi?id=339333 for more detailed discussion. > > KDE helper applications that need to be able to present widgets or otherwise > "talk with the GUI layer" require special attention on OS X, if one doesn't > want them to appear in the Dock or task switcher nor present a bare-bones > menubar when made active. > > Applications that live in an app bundle can set LSUIElement="1" in their > Info.plist to signal the window server that they're "agents" (and thus don't > want the aforementioned visual presence). This feature is already in use (see > Info.plis.template for apps like kded4 and kdeinit4, and the corresponding > code in their respective CMake files). > > kglobalaccel is a different case as it's built as a standard *n*x app > (`/opt/local/bin/kglobalaccel` in a standard MacPorts install) and thus has > no Info.plist. It is however possible to set the corresponding bit via > CoreFoundation, and that's what this patch does. > > Suggestion: a member function I'd tentatively call `appIsService` would be > welcome, but one could also make this the default behaviour when starting a > `GUIenabled=false` application on OS X. > That's actually the main reason for submitting this RR: see if we can come to > a consensus if and how to use this new knowledge. > > > Diffs > ----- > > kglobalaccel/main.cpp 4d230b8 > > Diff: https://git.reviewboard.kde.org/r/120354/diff/ > > > Testing > ------- > > On OS X 10.6.8 with kdelibs 4.14.1 (git/kde4.14). > > > Thanks, > > René J.V. Bertin > >
