2014-09-30 7:44 GMT+02:00 Gilles Caulier <[email protected]>: > 2014-09-30 3:06 GMT+02:00 Vishesh Handa <[email protected]>: >> Hey Tobias >> >> Some comments about the code - >> >> 1. The code seems to be licensed under GPL. In order to make it into a >> framework, it will need to be re-licensed. This library seems like an ideal >> candidate for becoming a framework. > > libkface have been writted in same way than libkipi, libkexiv2, and > libkdcraw, already in KDEGraphics. > > https://projects.kde.org/projects/kde/kdegraphics/libs/libkipi > https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2 > https://projects.kde.org/projects/kde/kdegraphics/libs/libkdcraw > >> >> 2. The copyright header seems to say "Part of the Digikam Project". You may >> want to change that. > > Idem here. libkface follow exactly the same way than libkipi, > libkexiv2, libkdcraw. > >> >> 3. There is an empty TODO file > > yes, this need to be filled.
Done : http://commits.kde.org/libkface/5ec950beeeed202d11ed2625000d2fb312a52b69 Gilles Caulier
