----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ -----------------------------------------------------------
(Updated Oct. 2, 2014, 7:10 p.m.) Review request for KDE Base Apps, KDE Software on Mac OS X, kdelibs, and Qt KDE. Repository: kde-baseapps Description ------- Mac OS X cannot handle the formatting used for title menu items when it applies to items in the toplevel menu bar. An application calling KMenu::addTitle on such a menu item will crash immediately, somewhere deep in Qt. This patch works around that crash by emulating the addTitle effect. Curiously, the addTitle call that causes the crash when clicking on the Help menu concerns a submenu of an item of the Tools menu... Diffs ----- konq-plugins/uachanger/uachangerplugin.cpp 5e2d094 Diff: https://git.reviewboard.kde.org/r/120355/diff/ Testing ------- OS X 10.6.8 with kdelibs 4.14.1 File Attachments (updated) ---------------- patch for qwidget_mac.mm https://git.reviewboard.kde.org/media/uploaded/files/2014/09/26/b5c2dd92-33db-4225-9750-d10e13f0f835__prevent_addTitleRelated_crash.patch with the Qt patch https://git.reviewboard.kde.org/media/uploaded/files/2014/09/26/96f4fbfa-854e-4596-9f5f-d82f98a06955__Screen_shot_2014-09-26_at_19.16.20.png with the addTitle emulation patch https://git.reviewboard.kde.org/media/uploaded/files/2014/09/26/5ddf4a63-b3bb-415a-815a-c06eb7a5c7f2__Screen_shot_2014-09-26_at_19.19.40.png Blimey, instead of a crash I get almost the intended addTitle effect! And yes, the Quit action has been moved by Qt... https://git.reviewboard.kde.org/media/uploaded/files/2014/10/02/d9f45b6f-f4dd-4ba8-93f9-efa798695f3f__Screen_shot_2014-10-02_at_19.05.34.png Thanks, René J.V. Bertin
