On 10 October 2014 09:08, Rolf Eike Beer <[email protected]> wrote: > Am 10.10.2014 08:46, schrieb Jaroslaw Staniek: >> >> On 10 October 2014 08:05, Rolf Eike Beer <[email protected]> wrote: >>>> >>>> Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) >>>> one >>>> but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix comes >>>> from >>>> libpredicate (master). >>> >>> >>> I see no upstream bug report for this. >> >> >> Would a bug report for Calligra master be OK for you? >> This is the only user of the PostgreSQL_TYPE_INCLUDE_DIR in entire KDE >> I the know about: >> >> http://lxr.kde.org/search?_filestring=&_string=PostgreSQL_INCLUDE_DIR > > > You are not looking for PostgreSQL_TYPE_INCLUDE_DIR here, but for > PostgreSQL_INCLUDE_DIR. And there seems to be no user of that at all inside > KDE.
Right, the use of PostgreSQL_TYPE_INCLUDE_DIR is under review today, the target is calligra master: https://git.reviewboard.kde.org/r/120545/ As you can see in that patch, I have a copy of the .cmake file (FindCalligraPostgreSQL.cmake ) but this is to make it work with what kdelibs that are currently distributed. > >> I am sorry if I misunderstood. >> >> Good thing that the file disappears in KF5, since cmake has pretty >> good own copy (not sufficient but I'll try to patch in the upstream). > > > CMake is the relevant upstream, Calligra is downstream (i.e. it uses our > stuff). That's ok for my plans. Thanks. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database applications creator tool - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek
