> On Oct. 19, 2014, 11:28 p.m., David Faure wrote: > > filenamesearch/kio_filenamesearch.cpp, line 135 > > <https://git.reviewboard.kde.org/r/120460/diff/1/?file=316056#file316056line135> > > > > Wow, won't this be really slow? which "remote" protocols is it > > typically used with? Any? Well, if it's an explicit request from the user I > > guess that's OK... > > Emmanuel Pescosta wrote: > This was introduced by > https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions/a683405089d76a47665a4225791a43d02c4a0f37 > > > Wow, won't this be really slow? > > Yes it will be slow ... > > > > which "remote" protocols is it typically used with? > > I guess mainly smb and nfs, but we don't have any usage statistics > > I don't know why Peter enabled search by content for remote files. It > makes sense for local files when Baloo is not present, but remote ... maybe > we should remove search by content for non-local files? What do you think?
I'm not sure. In a way, this is pretty much exactly what would happen when using "grep" on a kernel-level NFS or SMB mount. On a LAN setup, it might be useful. Of course doing this with an FTP server on the other side of the planet is probably crazy, but since the user is triggering it explicitly, they'll soon realize that it's crazy, when it takes 10 minutes to perform the search. KIO (and therefore most of the KDE software) tries to promise network transparency; any time we make things "local files only" we break that promise. So after all, I'm in favour of keeping it -- if it works, i.e. doesn't leak temp files :-) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120460/#review68733 ----------------------------------------------------------- On Oct. 13, 2014, 1:35 p.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120460/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 1:35 p.m.) > > > Review request for kde-workspace and David Faure. > > > Repository: kio-extras > > > Description > ------- > > The filenamesearch ioslave lists all files/folders which match with the given > search query. > > Made some small adjustments: > * Ported the ioslave to Qt5/KF5 > * Got rid of cleanup() and member variables > * Use lambda function validators instead of some weird if + assert things in > searchDirectory/contentContainsPattern > * Immediately return when the search string is empty > > https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions/frameworks/show/dolphin/src/search > > > Diffs > ----- > > filenamesearch/kio_filenamesearch.h PRE-CREATION > filenamesearch/kio_filenamesearch.cpp PRE-CREATION > CMakeLists.txt 2036392 > filenamesearch/CMakeLists.txt PRE-CREATION > filenamesearch/filenamesearch.protocol PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120460/diff/ > > > Testing > ------- > > Compiles. > > > Thanks, > > Emmanuel Pescosta > >
