----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121083/#review70150 -----------------------------------------------------------
Ship it! Other than that it should go in. liboxygen/CMakeLists.txt <https://git.reviewboard.kde.org/r/121083/#comment49079> remove trailing spaces. - Aleix Pol Gonzalez On Nov. 9, 2014, 2:23 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121083/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2014, 2:23 p.m.) > > > Review request for kde-workspace and kdewin. > > > Repository: oxygen > > > Description > ------- > > These files currently use > > ``` > __attribute__((visibility("..."))) > ``` > > which doesn't work on MSVC. > > > Diffs > ----- > > liboxygen/CMakeLists.txt 69b7bd2 > liboxygen/oxygen_config_export.h 02ea29d > liboxygen/oxygen_export.h b8877a0 > > Diff: https://git.reviewboard.kde.org/r/121083/diff/ > > > Testing > ------- > > Builds with msvc 2013 64bit > > > Thanks, > > Andrius da Costa Ribas > >
