----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70152 -----------------------------------------------------------
When I originally got KF5 to compile on windows I seem to remember having to do this a few times manually as well. Would it make sense to add the macro to KCoreAddons? - Alexander Richardson On Nov. 8, 2014, 11:26 nachm., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121080/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 11:26 nachm.) > > > Review request for KDE Base Apps, KDE Frameworks and kdewin. > > > Repository: kde-baseapps > > > Description > ------- > > Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is > not available. Implement it instead. > > > Diffs > ----- > > lib/konq/src/konq_historyentry.h de34d6b > > Diff: https://git.reviewboard.kde.org/r/121080/diff/ > > > Testing > ------- > > It builds (MSVC2013 - 64bit) after this patch (along other patches I'm > sending to review today). Kdebase-apps is still not very functional, though > (missing icons and weird UI). > > > Thanks, > > Andrius da Costa Ribas > >
