----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121511/#review71986 -----------------------------------------------------------
Don't change public headers. It's just that the no_strigi part of the .cpp code is broken, fix that part. - Albert Astals Cid On des. 14, 2014, 3:38 p.m., Paul Manners wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121511/ > ----------------------------------------------------------- > > (Updated des. 14, 2014, 3:38 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > Appears to be a syntax issue with kfilemetainfo.h and kfilemetainfo.cpp that > is breaking the build of kdelibs in the 4.13 branch. > > > Diffs > ----- > > kio/kio/kfilemetainfo.h 6920ffe > kio/kio/kfilemetainfo.cpp 84fb329 > > Diff: https://git.reviewboard.kde.org/r/121511/diff/ > > > Testing > ------- > > This appears to be a syntax error. > > This was causing problems when doing a build under Windows (with emerge > kdelibs under mingw4). Checking the source code of the kdelibs package in > Ubuntu (13.10), it appears to also suffer from the same error so this may be > a bigger issue than just on this branch. > > This fixes the build but I don't know how to check if it impacts any of the > other applications. > > > Thanks, > > Paul Manners > >
