> On Dec. 29, 2014, 10:49 p.m., David Faure wrote: > > I'm confused. Are you patching old code? > > > > kde-runtime branch Applications/14.12 has my rewrite of this code to use > > the cache as per the trash spec v1.0, replacing the KConfig-based code. > > It solves that issue. > > > > See commit 591acfe8f5e281f416ee925e1ff160c0aac81163 in kde-runtime.git.
obviously I use the wrong branch. Here on openSuse 13.1 I currently have KDE-4.14.3 and I thought this is the latest one ... But since you fixed the bug, why is it still open on bko ? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121746/#review72751 ----------------------------------------------------------- On Dec. 29, 2014, 10:43 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121746/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 10:43 p.m.) > > > Review request for KDE Runtime, David Faure and Tobias Koenig. > > > Bugs: 245482 > http://bugs.kde.org/show_bug.cgi?id=245482 > > > Repository: kde-runtime > > > Description > ------- > > The trash kio-slave stores the current trash size in a KConfig cache file. > However it can happen that the information inside this file is wrong, e.g. > when another (non-KDE) program puts some files into the trash. > This happens e.g. by using the ebook management software "calibre" when I > delete a book. calibre implements the FDO trash specification on its own and > therefore knows nothing about the KDE size cachefile. > > This leads to the problem that when I move a file out of the trash which was > put there by calibre, the subtraction underflows the cached size value > resulting in a wrong huge absolute number, finally leading to the bug > described here: > https://bugs.kde.org/show_bug.cgi?id=245482 > > > Diffs > ----- > > kioslave/trash/trashsizecache.cpp 2fae964 > > Diff: https://git.reviewboard.kde.org/r/121746/diff/ > > > Testing > ------- > > - unit tests > - calibre > > > Thanks, > > Martin Koller > >
