> On Січ. 27, 2015, 6:59 до полудня, Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > <https://git.reviewboard.kde.org/r/122270/diff/1/?file=345342#file345342line250> > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an xcb_connection_t - if that fails we don't > > have an X-Server. If it succeeds we can check the number of screens.
understood, but the question remains: is kcminit the best place to do multihead-related stuff? - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74806 ----------------------------------------------------------- On Січ. 27, 2015, 3:10 до полудня, Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122270/ > ----------------------------------------------------------- > > (Updated Січ. 27, 2015, 3:10 до полудня) > > > Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and > Lukáš Tinkl. > > > Repository: plasma-workspace > > > Description > ------- > > Now kcminit is linked with less libraries -> startup time improved > > I also suggest always setting KDE_MULTIHEAD=true to eliminate ini file access > during startup and to be able to stop linking against QtGui > > > Diffs > ----- > > startkde/kcminit/CMakeLists.txt ffae38c > startkde/kcminit/main.h 1140b77 > startkde/kcminit/main.cpp 4724323 > > Diff: https://git.reviewboard.kde.org/r/122270/diff/ > > > Testing > ------- > > compiled, ran 'kcminit --list' and kcminit AAA > > > Thanks, > > Nick Shaforostoff > >
