> On Лют. 3, 2015, 7:08 до полудня, Martin Gräßlin wrote: > > components/CMakeLists.txt, line 2 > > <https://git.reviewboard.kde.org/r/122320/diff/3/?file=346480#file346480line2> > > > > that seems unrelated change.
sorry, i forgot to remove it -- i had to comment it because i had compile errors there > On Лют. 3, 2015, 7:08 до полудня, Martin Gräßlin wrote: > > startkde/kcminit/CMakeLists.txt, line 16 > > <https://git.reviewboard.kde.org/r/122320/diff/3/?file=346481#file346481line16> > > > > you find optional, but link required. OSX devs won't be happy with that > > change ;-) > > > > you need to do something like: > > if (XCB_XCB_FOUND) > > target_link_libraries(kdeinit_kcminit XCB::XCB) > > endif() it compiles even if i remove find_package(XCB) -- XCB::XCB variable is just empty then > On Лют. 3, 2015, 7:08 до полудня, Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, line 26 > > <https://git.reviewboard.kde.org/r/122320/diff/3/?file=346482#file346482line26> > > > > the ifdef is wrong: HAVE_X11 is defined as 1 if Xlib is found. It > > doesn't say anything about whether XCB is found. Please introduce a > > dedicated ifdef for it. ok, and a dedicated <config-xcb.h> generated by cmake. will do it this evening - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122320/#review75256 ----------------------------------------------------------- On Лют. 2, 2015, 9:15 після полудня, Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122320/ > ----------------------------------------------------------- > > (Updated Лют. 2, 2015, 9:15 після полудня) > > > Review request for kde-workspace, Martin Gräßlin and Thomas Lübking. > > > Repository: plasma-workspace > > > Description > ------- > > this patch makes kcminit behave like in kde4: it uses proper xcb screen count > which may be different from QGuiApplication::screens().count(). > > for example when i connext external monitor via vga to my laptop, xcb screen > count is still '1', while QGuiApplication::screens().count() returns '2'. > > switching from QGuiApplication to QCoreApplication still wasn't possible > because modules like 'mouse' need gui initialized and would crash if kcminit > uses QCoreApplication. > > > Diffs > ----- > > components/CMakeLists.txt 42c820f > startkde/kcminit/CMakeLists.txt b17951f > startkde/kcminit/main.cpp 1008966 > > Diff: https://git.reviewboard.kde.org/r/122320/diff/ > > > Testing > ------- > > i have built kcminit on ubuntu vivid alpha 32-bit, replaced binaries and > libraries in the system and successfuly could run kcminit_startup and reboot > also went fine. > > > Thanks, > > Nick Shaforostoff > >