> On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS?
+1, notably since http://nonexistenfile won't be very helpful in dolphin, but will directly open a browser. One could end up on nasty pages. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75736 ----------------------------------------------------------- On Feb. 9, 2015, 12:48 nachm., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122475/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 12:48 nachm.) > > > Review request for KDE Base Apps. > > > Bugs: 343906 > http://bugs.kde.org/show_bug.cgi?id=343906 > > > Repository: kde-baseapps > > > Description > ------- > > URLs passed as commandline arguments should be constructed using > `QUrl::fromUserInput()` > > > Diffs > ----- > > dolphin/src/main.cpp 094402f > > Diff: https://git.reviewboard.kde.org/r/122475/diff/ > > > Testing > ------- > > dolphin /tmp > dolphin ftp.debian.org > > > Thanks, > > Arjun AK > >
