----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121755/#review83215 -----------------------------------------------------------
Ship it! the description makes a good commit message, so please make sure you use that (apart from adding the BUG lines). - Oswald Buddenhagen On July 29, 2015, 9:39 a.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121755/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 9:39 a.m.) > > > Review request for kde-workspace, Thomas Lübking and Oswald Buddenhagen. > > > Bugs: 268988 and 338018 > http://bugs.kde.org/show_bug.cgi?id=268988 > http://bugs.kde.org/show_bug.cgi?id=338018 > > > Repository: kde-workspace > > > Description > ------- > > [Commit > d03df616](https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/d03df6169ecb291318e87099a346488c961fe1d6) > made input grabbing optional in KDM. But without it, input dialogs do not > correctly get focus and keyboard shortcuts don't work. > > KDM does call activateWindow() on opened dialogs, but this doesn't seem to > have the desired effect without a window manager running. And if you hover > the mouse over a widget, it visually looks like it has focus, but often it > doesn't accept input anyway. > > This patch sets the input focus via XSetInputFocus() instead, this also has > the positive side-effect that a widget retains the focus if you move the > mouse away. > > > Diffs > ----- > > kdm/kfrontend/kfdialog.cpp 3f6fa84 > > Diff: https://git.reviewboard.kde.org/r/121755/diff/ > > > Testing > ------- > > Tried all things mentioned in the bug reports, keyboard input and shortcuts > work now in all cases. > > I also tested with onboard keyboards (xvkbd and kvkbd), both work fine. > Before, kvkbd didn't work at all (the text input widget lost focus as soon as > you moved the mouse to the OSK) and xvkbd only works if you forced the focus > to the text input widget via its "Focus" button (from which this patch was > inspired actually ;-) ). > > Other openSUSE users have tested this as well, and the patch is even part of > openSUSE's official package since January. > See also https://bugzilla.opensuse.org/show_bug.cgi?id=772344 > > > Thanks, > > Wolfgang Bauer > >
