> On Oct. 2, 2015, 7:32 a.m., David Faure wrote: > > Looks good, except for a bug in the commit log. You meant "should have been > > toLocalFile()" instead of "should have been path()" ;) > > Sergio Martins wrote: > which return the same thing for local files, innit ?
No it doesn't, not on Windows. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125476/#review86216 ----------------------------------------------------------- On Oct. 2, 2015, 3:19 p.m., Sergio Martins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125476/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 3:19 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kio > > > Description > ------- > > - Passing openUrl.toString() is wrong, it should have been openUrl.path(), > since the former has a scheme, and QFileDialog will call > QUrl::fromLocalFile() on it. > - QFileDialog::getExistingDirectory() internally calls > QFileDialog::getExistingDirectoryUrl() and converts the result to a local > file string, which we then were re-converting to QUrl again, so instead just > call getExistingDirectoryUrl() directly. > > > Diffs > ----- > > src/widgets/kurlrequester.cpp 1b3bbdf > > Diff: https://git.reviewboard.kde.org/r/125476/diff/ > > > Testing > ------- > > > Thanks, > > Sergio Martins > >
