----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119892/#review86318 -----------------------------------------------------------
lib/konq/konq_operations.cpp (line 441) <https://git.reviewboard.kde.org/r/119892/#comment59466> Yes, dropping a file onto an executable sounds like a good feature to have. Why disable it? It seems unrelated to the feature in this patch; just select the correct code path depending on whether you're dropping onto an executable or an archive.... Basically, refactor the code in the next hunk, which finds out if ark supports that mimetype, into a separate function that returns true if supported by ark, false if not. Doing the KService lookup twice is not a problem. - David Faure On Sept. 4, 2014, 7:20 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119892/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 7:20 a.m.) > > > Review request for KDE Base Apps, KDE Utils and David Faure. > > > Bugs: 338414 > http://bugs.kde.org/show_bug.cgi?id=338414 > > > Repository: kde-baseapps > > > Description > ------- > > This patch implements the "Add to archive" option, which is shown when a user > drags and drops files onto an existing archive. > > > See also: > https://git.reviewboard.kde.org/r/119890 > https://bugs.kde.org/show_bug.cgi?id=338414 > > > Diffs > ----- > > dolphin/src/views/dolphinview.cpp 02b8815 > dolphin/src/views/draganddrophelper.cpp f8ae0ad > lib/konq/konq_operations.cpp 220a90a > > Diff: https://git.reviewboard.kde.org/r/119892/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
