----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127006/#review92312 -----------------------------------------------------------
Ship it! (feel free to add me as reviewer for konqueror patches, I only noticed this one by chance) - David Faure On Feb. 7, 2016, 9:07 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127006/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2016, 9:07 p.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > These changes to Konqueror's setting up of actions eliminate the runtime > debug messages: > > konqueror(3420)/default err_method_notfound: QObject::connect: No such signal > QAction::triggered(Qt::MouseButtons,Qt::KeyboardModifiers) in > /ws/frameworks/applications/kdebaseapps/konqueror/src/konqmainwindow.cpp:3637 > > and one for each action: > > konqueror(3420)/default KXMLGUIFactoryPrivate::saveDefaultActionProperties: > Shortcut for action "new_window" "New &Window" set with > QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead. > > and also a number of compiler warnings: > > konqueror/src/konqmainwindow.cpp:3705: warning: ‘KShortcut’ is deprecated > > > Diffs > ----- > > konqueror/src/konqmainwindow.cpp c7a81c8 > > Diff: https://git.reviewboard.kde.org/r/127006/diff/ > > > Testing > ------- > > Built Konqueror with these changes. Observed absence of those compiler and > runtime error messages, checked correct operation of key shortcuts. > > > Thanks, > > Jonathan Marten > >
