> On March 3, 2016, 5:54 p.m., Aleix Pol Gonzalez wrote: > > cmake/modules/KDE4Macros.cmake, line 1003 > > <https://git.reviewboard.kde.org/r/127264/diff/1/?file=447921#file447921line1003> > > > > Without the conditionals, the code would work just as well. > > Rohan Garg wrote: > Unless you have a CMake so old that said policy doesn't exist. For eg. on > Debian stable :) > > Luigi Toscano wrote: > (which is still 3.0.2, so way more than the minimum required version for > Frameworks (2.8.12)) > > Rohan Garg wrote: > Except we're talking about kdelibs here, from the KDE 4 era. > > Luigi Toscano wrote: > Even better (for your patch)! 2.8.9 is the current minimum, so not old at > all for kdelibs4. > > Rohan Garg wrote: > Maybe I'm doing a terrible job of explaining it. The CMP0064 policy was > introduced in v3.4 , which is not available in Debian stable. Does that clear > things up? Or am I missing something?
I'm supporting your patch. My comment is in fact to point out that version of cmake is not so old. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127264/#review93107 ----------------------------------------------------------- On March 3, 2016, 1:58 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127264/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 1:58 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kdelibs > > > Description > ------- > > This follows the same idea from 826a5ff3278f492a99ac6827614e1d0ca40a45e8 > > > Diffs > ----- > > cmake/modules/KDE4Macros.cmake 5bb2ffa > > Diff: https://git.reviewboard.kde.org/r/127264/diff/ > > > Testing > ------- > > > Thanks, > > Rohan Garg > >