> On März 21, 2016, 4:08 nachm., Martin Klapetek wrote: > > Thanks! > > Daniel Faust wrote: > I already started to rewrite the clock applet. I got pretty far actually, > and this issue arose again. > I think it was always intended to use the default font size in narrow > panels, but since font.pointSize and font.pixelSize were both set, > setting pointSize to the default font size never worked. > > So now my tendecy is to use the default font size and post my changes > once I'm done.
Now that Plasma 5.6 has arrived in opensuse Tumbleweed, I was finally able to finish my re-write. It uses the default font size for all labels in narrow panels. I'm pretty sure that was always the intended way plus I think it looks better than using a scaled font. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127393/#review93821 ----------------------------------------------------------- On März 19, 2016, 2:16 nachm., Daniel Faust wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127393/ > ----------------------------------------------------------- > > (Updated März 19, 2016, 2:16 nachm.) > > > Review request for kde-workspace. > > > Bugs: 360059 > https://bugs.kde.org/show_bug.cgi?id=360059 > > > Repository: plasma-workspace > > > Description > ------- > > Currently the digital clock applet uses a fixed font size for the date label > when it's placed in a narrow horizontal panel. > Example: http://paste.opensuse.org/view/raw/f8ba5d0d > > With this patch the same font size is used as for the time label. > > As mentioned at https://git.reviewboard.kde.org/r/127102/ I'm not sure if the > current design is a bug or intentional. > On the one hand having a smaller font size reduces the width of the applet, > on the other hand having the same font size is more consistent. > I would prefer a consistent look however. > > This patch creates one problem though. Currently the height of the > date-time-separator is set to the height of the (fixed) date label font size. > With this patch I set the separator height to 70% of the applet height. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml 02d55a9 > > Diff: https://git.reviewboard.kde.org/r/127393/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Faust > >