> On May 17, 2016, 2:35 p.m., Martin Gräßlin wrote: > > The change looks sensible to me, but I would appreciate a test case for it. > > There are already some tests for the file dialog, so it should be easy to > > extend.
There is no autotest, but have updated tests/qfiledialogtest with options '--confirmOverwrite' (on or off) and '--nativeDialog' (on or off). Checked operation of these options and overwrite warning. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95532 ----------------------------------------------------------- On May 17, 2016, 3:20 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127944/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 3:20 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 360666 > https://bugs.kde.org/show_bug.cgi?id=360666 > > > Repository: plasma-integration > > > Description > ------- > > The referenced bug says that, by default, there is no file overwrite check > when using QFileDialog to save a file. Indeed, on closer investigating it > appears that there is no way to even explictly force an overwrite check when > using the KDE platform theme, because of this code in > plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp: > > // overwrite option > if > (options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite)) > { > dialog->m_fileWidget->setConfirmOverwrite(false); > } > > The default for KFileWidget is already for no overwrite check (as set in > kio/src/filewidgets/kfilewidget.cpp which initialises > KFileWidgetPrivate::confirmOverwrite to false). There is no way to override > this from the calling application through the platform plugin. > > Suggest that the default option should be the same as that defined by Qt for > QFileDialog: always perform an ovewrwrite check on saving, unless the caller > has set the QFileDialog::DontConfirmOverwrite option. This is also a > sensible default to have from the user's point of view. This change does > that in the platform theme plugin, for all saving operations. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d > tests/qfiledialogtest.cpp 1d69ea1 > > Diff: https://git.reviewboard.kde.org/r/127944/diff/ > > > Testing > ------- > > Built plasma-intergration with this change, confirmed correct operation of > file dialogues and that confirmation is requested when overwriting an > existing file, unless the QFileDialog::DontConfirmOverwrite option is > specified. > > > Thanks, > > Jonathan Marten > >
