> On June 12, 2016, 3:31 p.m., Albert Astals Cid wrote: > > the file contains only whitespace changes. Is that right? > > > > Also i can't find that commit in solid.
Yes, that is right. `"foo"bar` is now interpreted as a C++11 user-defined string literal, and you need to add a space if you want it interpreted as `"foo"` compile-time concatenated with the expanded value of the macro `bar`. - Nicolás ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128160/#review96383 ----------------------------------------------------------- On June 12, 2016, 1:40 p.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128160/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 1:40 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > This basically backports 3c38c2bba3dc2313fa95ff99c76aae3870e0a168 > from solid. > > > Diffs > ----- > > solid/solid/backends/shared/cpufeatures.cpp > baa1af21098d7c312d7a9176e216d9d0f8e3a7a6 > > Diff: https://git.reviewboard.kde.org/r/128160/diff/ > > > Testing > ------- > > Not enough to successfully compile with gcc-6, but at least one error less. > > > Thanks, > > Heiko Becker > >
